Jordi Gil comments

Results 9 comments of


                                            Jordi Gil

Change generic yaml.load() references to use safe_load()

@samvarankashyap can you help review this PR, or suggest someone else instead? Much appreciated! :smile:

Change generic yaml.load() references to use safe_load()

Hi @junqizhang, can you take a look at this PR? /assign @junqizhang

Change generic yaml.load() references to use safe_load()

/retest

Change generic yaml.load() references to use safe_load()

> The tests are failing They are failing in setting up the environment (downloading dependencies). I don't think my changes are the culprit for this error. Is there any way...

Change generic yaml.load() references to use safe_load()

@JunqiZhang0 can you trigger the tests? I think I've fixed the environment issue. Thanks :smile:

Flake: external gateway LANE: [FAIL] External Gateway With Admin Policy Based External Route CRs BFD e2e non-vxlan external gateway through a dynamic hop Should validate TCP/UDP connectivity to an external gateway's loopback address via a pod with a dynamic hop [It] TCP ipv4

Can we disable them for now? I don't have time to look at them right now (and don't know when I can commit to it) but disabling the whole line...

Fix buildah clustertask to support long image names

> /hold The `buildah` Task is going to be maintained from [`openshift-pipelines/task-containers`](https://github.com/openshift-pipelines/task-containers), so the change would need to be there. Though I am not entirely sure it is affected there....

Fix buildah clustertask to support long image names

> > > /hold The `buildah` Task is going to be maintained from [`openshift-pipelines/task-containers`](https://github.com/openshift-pipelines/task-containers), so the change would need to be there. Though I am not entirely sure it is...

abproute: Do not fail when a pod has bad gw config

@zeeke as far as I know, the APB annotations are deprecated and replaced by the [APB External Route CRD](https://ovn-kubernetes.io/api-reference/admin-epbr-api-spec/). Is it possible for you to [replace](https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/network_apis/adminpolicybasedexternalroute-k8s-ovn-org-v1) the annotation with a...