Jordan Carlin

Results 196 comments of Jordan Carlin

>You may want to wait for #448 which will remove at least some of the changes needed. It's waiting for a new version of the Sail compiler to be released....

@Timmmm Thanks for all your earlier comments. I believe I’ve taken care of all of them at this point. I’d appreciate it if you could give this another look. Aside...

@ShivangMishra Is this still something you're planning to work on? If not I would be interested in giving it a go.

This can be closed now that #534 was merged instead.

Now that #444 and #464 are merged, can this be closed?

Probably worth merging an updated version of #370 before we merge this to prevent issues for anyone still running Sail 0.17. That way they will at least get a descriptive...

Looking at this and it's making me wonder if the names for all of the modules make sense right now. For example, the `zbb` module is now instantiated if either...

If you want me to change it I'm happy to do so, but I think leaving it together is probably fine. I was more so focused on whether naming the...

Oh. I totally missed that. I saw that the issue preventing Zfa tests from working was resolved so figured I’d switch over, but let’s definitely wait on restructuring tests.vh until...