Alexey Velikiy

Add hastic.io tool to the list

I thing we should remove this: https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L207 I found hardcoded port here: https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L79 I find it suspicious that we resolve our promise here: https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L147 we don't guarantee that task will...

bad constants in analytics_controller.ts

2

I don't like that we duplicate this line: https://github.com/hastic/hastic-server/blob/ae5df8745535bbd1e9a98283587f7f2485cf41a2/server/src/controllers/analytics_controller.ts#L168 maybe we can make a env variable for this?

We list functions and define variables in the module scope. I don't like it, let's create a proper class as we do in AnalyticsService, for example

If you do fresh `npm run dev` after `npm install` ``` > [email protected] dev /home/corp/temp_projects/hastic/hastic-server/server > NODE_ENV=development node build/dev-server.js nodemon started internal/modules/cjs/loader.js:638 throw err; ^ Error: Cannot find module '/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js'...

Logging abstraction

2

There is a case when we use (please don't ask why) different kind of logging: https://github.com/hastic/hastic-server/blob/ae5df8745535bbd1e9a98283587f7f2485cf41a2/server/src/services/analytics_service.ts#L64 I propose to have a config and special code everywhere in the codebase where...

Imagine a metric which you store only for two weeks. How would hastic behave if I label an anomaly each day and then want to see detections in the past

There is a neat implementation of runners in gitlab: https://docs.gitlab.com/runner/ We can think about our analytic processes as runners. If we think this way, then we should not accept connections...

If we can't open port, then lets do something like: ``` nginx: [emerg] bind() to 0.0.0.0:80 failed (98: Address already in use) nginx: [emerg] bind() to [::]:80 failed (98: Address...

Dataframe doesn`t contain timestamp:

2

 the error  info: