jonsyu1

Results 6 comments of jonsyu1

Weak disagreement. I would note that the superior [errors](https://github.com/pkg/errors) package supports the return `nil` [behavior](https://github.com/pkg/errors/blob/master/errors.go#L163). I don't have strong feelings on this once we switch to pkg/errors, because we no...

RE: what would it take: - [ ] use `%+v` formatting directive - [ ] replace `stacktrace.Propagate` with `errors.Wrap` and `stacktrace.NewError` with `errors.New` - [ ] for functions that use...

I still disagree with your argument that the propagate/wrap call with possibly nil error is bad style. Let's observe how error handling looks like in idiomatic go: https://golang.org/src/encoding/json/encode.go?h=return+err#L824 ``` 822...

Caught up with Nick offline. I'm warming up to the idea of only wrapping non-nil errors. The example that convinced me is `fmt.Errorf`. It's the standard library's equivalent of `errors.Wrap`,...

This endpoint serves both old and new summaries. The old summaries could return raw types like `optional` but the new summaries return a conjure-defined struct or union type that wraps...

Only private functions, just like the go linter's unused variable check.