Jon Schwenk

Results 28 comments of Jon Schwenk

+1 for reopening this one.

The short answer is no, you can't use generic watershed boundaries to do aggregations. This is mainly due to the fields that rabpro expects to see that it uses to...

Added the following to the paper: > `rabpro` does not currently provide support for custom watershed datasets similar to HydroBASINS due to attribute field and data structure requirements that must...

I can't think of a reason this wouldn't be fairly simple off the top of my head, but there might be some baked-in assumptions about CRS and/or pixel resolution that...

That would be a nice addition, wxee looks cool.

Thanks @elbeejay! Interesting that the Warning that this issue was opened for doesn't show up in the tests. `regionprops` is tested [here](https://github.com/jonschwenk/RivGraph/blob/78670fbab67f62a222c019e61ff638be06649391/tests/test_im_utils.py#L401), so perhaps package updates resolved that particular Warning?...

Looks nice! You also might want to add a check that the rasters have the same CRS? I think that can get a little hairy if you rely just on...

@mwort Congrats on getting to a stable point! I am wondering if it would make sense to set up another meeting for you to catch us up on your improvements....

Running `compute_topologic_metrics` calls `ensure_single_inlet` which removes any inlets (and then dangling links) besides the widest one. This is currently hard-coded. I see three issues here to address - [ ]...

In short, we abstracted too much control from the user with the `compute_topologic_metrics` function and I'm suggesting that you take that control back yourself. We could also consider scrapping the...