Jonny Reeves comments

Results 5 comments of


                                            Jonny Reeves

Implement the spec to make this a compliant implementation

It would appear @hoisie has gone a little quiet. Thanks for much for this work @jabley - this implementation solves a lot of problems when trying to get Mustache templates...

Replace `x-grpc-web` header with `X-User-Agent`

Note that making this change will prevent us from detecting grpcweb requests in the CORS Preflight (OPTIONS request) handler (see discussion in https://github.com/grpc/grpc-web/issues/85). If implemented, the `grpcweb` middleware will handle...

WIP: Add generate parameter - Fixes #211

Thank you for raising this. WRT code structure, can I suggest that you introduce a 'proper' type for the Parameters object instead of relying on `{[key: string]: string[]}` - this...

Cancelation support for unary responses

Yep; we also need to expose metadata on unary calls as well.

Inconsistency between exclude and allowOnly

I believe this issue is fixed by #179 as the `--allowOnly` check is now performed after any filtering/restriction of packages.