Jonny Nott
Jonny Nott
@adrilo @PeteAUK @fwwarr
> Thanks @jonnott for your contribution! It looks good overall. I just left 2 minor comments that should be addressed before I can merge. Hi @adrilo, I've force-pushed an amended...
@adrilo Do you see any outstanding issues with this still preventing a merge?
Anyone know if there's any likelihood that this will get merged any time soon? Or do I need to submit this PR to openspout/openspout and look to use that in...
@taylorotwell @valorin While I can understand the usefulness of adding the `$ignore` property into the core framework middleware, I'm not sure how adding yet another 'stock' piece of app-level middleware...
@valorin I feel the best solution is to ship the skeleton with only middlewares that serve the 98% common use case (i.e. middlewares that 98% of apps will actually need),...
> Implementing the feature is the easiest part, we need the test first. I've updated with a working implementation and passing test for XLSX. I have *no idea* how to...
@Slamdunk
> (the only thing that I can't comprehend is why @jonnott used `string` variable to store the height and not `float`) @delameter Feel free to change this if you feel...
> > (the only thing that I can't comprehend is why @jonnott used `string` variable to store the height and not `float`) > > @delameter Feel free to change this...