Lee Jongwoo comments

Results 8 comments of


                                            Lee Jongwoo

KeyFilter: KeyFilter validation does not work correctly with IME (Combinatorial Input)

When I looked at the source code, I noticed that the value validation is being done in the keypress eventListener (named onKeyDown), but the keypress event is not fired when...

KeyFilter: Doesn't seem to be working as expected

It seems to be the same issue as [this](https://github.com/primefaces/primevue/issues/6724)

How to evaluate rags in other language

I’m not sure exactly what you’re trying to do, but if you want to evaluate an English dataset and obtain results in other languages, you may check out [this page](https://docs.ragas.io/en/stable/howtos/customizations/metrics/_metrics_language_adaptation/)....

Fix improper handling of msg.results in chunk callbacks (#964)

Sure. Should I add test to the node_test.js and CUSTOM_TEST in test-cases.js?

Fix improper handling of msg.results in chunk callbacks (#964)

I've addressed my mistakes and adding tests. Please let me know if there's anything else that needs to be adjusted. Thank you for your guidance!

Fix improper handling of msg.results in chunk callbacks (#964)

Previous fixes didn't work on node environments 😅. When using `ChunkStreamer` in a node environment, the `_completeResults` value being passed to `complete` was being set to `undefined` if the user...

Fix improper handling of msg.results in chunk callbacks (#964)

Hi @pokoli just checking in to see if there’s any feedback or updates on this PR. Let me know if I should adjust anything. Thanks!

Fix improper handling of msg.results in chunk callbacks (#964)

Hi @pokoli Could you please take another look when you have a moment?