Jonathan D. Johnson

Results 36 comments of Jonathan D. Johnson

As mentioned in #3, we probably want some work to be done to prevent it from attaching globally, if a module system (AMD/CommonJS) is in use. Returning only the `BubbleChart`...

:disappointed: probably should handle the methods in `patches.coffee` better, probably should not be extending the Canvas prototype :grimacing: and maybe there is a requestAnimationFrame polyfill available on npm? Been awhile...

Thanks! Back when this was originally built I did not do a good job of making it play well with module loaders. I would definitely accept a Pull Request to...

Right, but I think we also need to make sure it doesn't attach globally when required, but return the `BubbleChart` class. It should only attach globally when not requiring via...

Thanks for this. Seems like an interesting approach and certainly fits your needs, but I think it's not quite generic enough a solution. I'd like to see this solved with...

Also, make sure all pull requests are targeted at the `develop` branch. Thanks! (should probably update CONTRIBUTING.md)

For sure! Any ideas on what is keeping this from working today? Maybe we just need a `main` entry in our `package.json`? If you want to experiment with how, I'd...

Yes, sorry y'all (#8). I do think this work is very helpful for those that want to opt-in to scaled `drawImage` functionality. Hopefully folks find this that need it. Thanks...

@YingshanDeng I hear you, and make no mistake this was an intentional decision. The primary reason for this is that by scaling image drawing, we're making a decision for the...

Thanks for the report! Conceptually this makes sense since we are tinkering with the drawing dimensions behind the scenes. In reviewing the documentation for [isPointInPath](https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/isPointInPath), it looks like it can...