Jon Church
Jon Church
Related #1003 ?
From what I can tell, `app.param` is being removed from Express in v5, so unless there are still plans to land this in 4.x, this PR can likely be closed.
Ahh thank you @dougwilson, I see now that [this commit](https://github.com/expressjs/express/commit/1e2951a832d1307ab40ef8c45202e02524991816) was reverted by this [later commit](https://github.com/expressjs/express/commit/509ebb1aff11749a9608f2a1ed2117766800d883).
I realized after opening this that Node.js does not throw on inputs like `500.5`, this PR however does. From the other PR, I think we decided to throw on these...
Fixed the tests. Now the CI fails on Node.js 0.10 because there is no `Number.isInteger` function available there. Assuming we're dropping that version, then this should be good to go...
Thinking more about this and something bothers me. I took the approach the previous PR did, since it had been reviewed, but now I'm questioning the use of `res.status` internally...
I wasn't clear. Re: breaking, I meant that someone's v4 `res.status` monkey patch might affect code in unexpected ways under v5, because it is used in more places than before....
Just read that linked comment and saw you did directly address the concern already 👍
@kevinsimper If you'll humor me, I'm curious to learn more about your use case. I'm not sure this is the best issue to discuss this, the conversation around moving req/res...
Well their included link points to `router.handle`, which is labeled private in the jsdoc (not saying you're wrong, just pointing out the context)