Jon Armen
Jon Armen
@ptrthomas , absolutely. I'll see if I can get that for you shortly. Would you happen to have an ETA when this change could be released?
@ptrthomas , understandable. I am definitely excited to see the progress you have been making on this project, and the 1.20 release is another great milestone.
@ptrthomas I've updated the samples to include tests. Verified before these samples would fail, and now they pass.
@ptrthomas , I'm not familiar with your build system, but is it possible it's using jar's from Karate 1.2.0 rather than from Core? I noticed when I was running it...
@ptrthomas , got it. I can also repo it locally.
@ptrthomas , thank you for your responsiveness getting these changes incorporated. much appreciated.
@prnbtr09 , I had this issue as well when I was working on this. I found that when replacing the handler, I often had to use karate.toJava() `webSocketClient.setTextHandler(karate.toJava(msgHandlerDelegate));`
@ptrthomas , I haven't had the chance to fully test this on my project yet. When upgrading to 1.2.0, we have a series of failures due to sequencing of calling...
@ptrthomas , Apologies for not getting back sooner, No worries about a breaking change on the implementation. I'll try to test it out in the next few days.
@ashishdhingra - I have submitted #1089 for this issue. @qidydl , do you believe this would resolve?