Jonathan Lelievre comments

Results 109 comments of


                                            Jonathan Lelievre

What is the difference and relationship between PositionColumn and DraggableColumn ?

This is related to this issue as well https://github.com/PrestaShop/PrestaShop/issues/12368 Category grid has a different way of handling its position, mainly because the algorithm is different and uses nested tree This...

Adding the PATCH method to the REST API (webservices)

Hi @nsorosac and @khouloudbelguith I took the liberty to rebase the PR to avoid losing some time. @khouloudbelguith it should be testable now.

Update stock movement DB employee fields

This PR is related to this core PR https://github.com/PrestaShop/PrestaShop/pull/28640/files Which hasn't been merged yet for 8.0, and it should be delayed for 8.1 instead

Update 8.1.0.sql, add hook actionProductPriceCalculation

Closed in favor of https://github.com/PrestaShop/autoupgrade/pull/525 Sorry @carmas123 I tried to update your branch to update this PR but I failed, I was able to rebase your dev branch (which is...

Fix line not compatible with PHP < 7

@okom3pom ah yes my bad Thanks (and sorry) @Prestaworks I reviewed a bunch of PR on autoupgrade and I messed with the authors, my bad 😅

Fix discount detail in cart when a product has en ecotax with applied tax

Thanks @mflasquin and @florine2623

[PHP8.1]/[PHP8.0] PATCH for endpoint /api/products/{product_id}/ and /api/categories/{category_id} are NOK

It's not the same endpoints, this PR is about entities endpoints. The https://github.com/PrestaShop/PrestaShop/issues/29653 is about images of these entities.

[PHP8.1]/[PHP8.0] PATCH for endpoint /api/products/{product_id}/ and /api/categories/{category_id} are NOK

Fixed by #29756

Fix images for objects without name or rewrite

Thanks @Hlavtox and @sallemiines

Fix ordering by product name + add ordering by product id (movements page)

My bad @marsaldev you're right it's a different issue that should be fixed separately. And sorry @marwachelly my comments maybe was confusing but this PR is perfectly testable for the...