Mehdi Amini

Results 100 comments of Mehdi Amini

> CHECK and DIE are intended to be enabled in release builds LLVM has `report_fatal_error` for this, does it match your "DIE" use case? > We want them enabled so...

It works if you have a prebuilt LLVM or if you run `ninja check` and not `ninja check-flang` specifically.

I'm happy to offer you a branch in the mlir-hlo repo for managing this, but the HEAD of the repo is cadenced by Google internal integration: we bump it when...

@ashay you should have an invite to joint the TensorFlow organization, which will give you write access to the mlir-hlo repository: I created a `greencommit` branch for you, but if...

You should be able to push a new branch instead of renaming it right?

Actually let me adjust the permission, seems like it is blocked...

I deleted greencommit so you can push under the namespace now

I wonder if `DefaultValuedAttr` would have generated what @apaszke expected here? (didn't have time to try it yet)

I think this should be a utility and not a method: it looks like an accessor but has non-trivial cost.

This isn't directly in my scope, maybe @karimnosseir can help?