johnlockwood-wf
johnlockwood-wf
In the spirit of being safe, would you add some unit tests to this?
It would help me understand your example test if there was a before and after of what the change unbreaks. What went from red to green?
@dgrijalva In the example @leetal posted, I want to understand what part is broken before this code change and thus what is fixed after. Maybe if he shows the output...
I do think this change would add confusion.
I don't understand the need to have the number anything but `float64` or `json.Number`.
Adding support of some arbitrary other number types to this lib doesn't make sense.
@leetal I have been looking at the Valid method as if it is exclusively used for validating what has been unmarshalled from JSON. But, you're using it to validate a...
Yes. I'll try my hand at making a PR for it.
How will we want run_job to handle an async abort if it is part of a larger job? Send an abort signal to all others? Treat that task as done...