johnhuichen

Results 15 comments of johnhuichen

I am not able to push my branch though. @tjdevries ![Screenshot from 2023-10-20 07-34-45](https://github.com/tjdevries/vim9jit/assets/15637790/4a4d7e8e-36e0-4d8a-8eb5-15729a9ebd8c)

Ah thanks, I haven't worked with open source too much

Currently similar code but for the trait is formatted OK ```rust trait SomeTrait: BBBBBBBBBBBBBBB< CCCCCCCCCCCCCCCCC, DDDDDDDDDDDDDDDDD, EEEEEEEEEEEEEEEEE, FFFFFFFFFFFFFFFFF, GGGGGGGGGGGGGGGGG, HHHHHHHHHHHHHHHHH, IIIIIIIIIIIIIIIII, > + Eq + PartialEq { } ``` whereas...

@ytmimi I found that when rewriting `TyAlias`, it calls `join_bounds_inner`(src/types.rs) twice, which will update the shape to increment indent by 4. The problem is that to rewrite the generics inside...

@ytmimi after some digging, I still think the problem is with inconsistent formatting. Since bounds is used by both trait and type, you can't without difficulty format traits as ```rust...

@calebcartwright bounds rewrite implementation was changed in Version 2 to fix ```rust pub trait PrettyPrinter { // } ``` But the fix broke formatting for type alias. I didn't find...

> Thank you both for the work on this, just noting I've added some labels to indicate the criticality of this one as it ties into 2024 deliverables. > >...