John Ingles
John Ingles
As far as I can tell _stream.write(string) is just calling stdout.write(string). I don't think stdout can detect encoding on its own.
Can confirm it still doesn't work on windows 10. I had to add delete=False to tempfile.NamedTemporaryFile()
I can get log output like this. I don't know about traceback handling though. ``` import logging from starlite.logging import LoggingConfig config = LoggingConfig( handlers={ "console": { "class": "logging.StreamHandler", "level":...
Maybe add ```"rich_tracebacks": True``` to the rich handler in handlers would be enough?
I got tracebacks to work by setting rich_tracebacks to True and the level to Error. Now the question is, should this be an integration or should we just use the...
@cofin @Goldziher If the title is now "Enhancement: Rich and StructLog integration", does that mean we want to add rich and structlog to the default LoggingConfig model (along with those...
@Swannbm The last line config.dictConfig(....) is how it's written in the current \_\_init\_\_ file. I can change that if we are all in agreement. I'll work on putting together a...
@Swannbm Can you explain your comment "I will instanciate logging in the middlewarelogging stuff.". I did a search of the repo for middleware and couldn't find anything related to logging....
@Swannbm Ok, I'll wait for your work to be finished before doing mine to ensure there is no conflict. Take you time
I don't see anything in the draft that would interfere with this.