Jonathan Goldwasser

Results 24 comments of Jonathan Goldwasser

See https://github.com/jogold/cloudstructs/blob/master/src/toolkit-cleaner/README.md for a working construct that does asset garbage collection.

See https://github.com/jogold/cloudstructs/blob/master/src/toolkit-cleaner/README.md for a working construct that does asset garbage collection.

Looks like something for [`cdk-assets`](https://github.com/aws/aws-cdk/tree/master/packages/cdk-assets)?

@andreimcristof you could use a custom resource for this ( https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-cloudformation/README.md#custom-resources and https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/template-custom-resources.html).

@eladb any feedback on this? do you think this is of interest for the CDK? Example of a `DnsWrapper` could be: ```ts class DnsWrapper extends cdk.Construct { public readonly domainName:...

Hi @r24y, In your setup where are your `package.json` and `webpack.config.js` located?

Hello @aymericbeaumet, Thank you for your message. I'm currently not using `serverless-offline` in my projects, have you tried it already with this plugin ? Regarding the `webpackIncludeModules` option, what do...

@eladb what do you think here? Should we simply disable bundling when staging is disabled? `if (props.bundling && !stagingDisabled) {` https://github.com/aws/aws-cdk/blob/d28752513175c94fb2bc4da43374d7f2e66d6550/packages/%40aws-cdk/core/lib/asset-staging.ts#L91-L93

> Will esbuild still compile or does it just use what was compiled from `tsc`? esbuild will use what was compiled from `tsc`

Looks like for some (unknown) reason an empty zip file landed on S3 for this asset. It should be fixed If you manually remove the asset file from the bootstrap...