Joe Westcott

Results 23 comments of Joe Westcott

How's this project going, @d1ngd0?

@jung-kurt Do you think it's better to find an external package to do the rasterisation for us, as described above, or to continue with our implementation of parsing and drawing...

> It seems that it is the reader's responsibility to stack and unstack the attributes before and after a transformation. How do you read that? It seems like that's the...

> I just commited 6b7c17b that makes graphic property assignments unconditional. ExampleFpdf_SetFillColor shows transformations working as expected. Amazing! Thanks for doing this. I've noticed a few more setters in the...

I'd like to mention calculating font width isn't as simple as summing up `advanceWidth` if you care about font [Kerning](https://en.wikipedia.org/wiki/Kerning), which is something I'd like to see in this library...

Hi @tavoyne, > You're right, we need to care about kerning as well. Thanks. Currently, `pdf-lib` doesn't actually write the character kern offsets to the document, but `widthOfTextAtSize` **does** include...

This library can parse the _structure_ of an existing PDF document (for deleting, re-ordering, or adding content to pages), but has no capability to edit existing page content. See [Limitations](https://github.com/Hopding/pdf-lib#limitations)...

Hi @qlynick, Font subsetting is not well supported right now. See https://github.com/Hopding/pdf-lib/issues/494#issuecomment-695818400. A fix for subsetting is [here](https://github.com/Hopding/fontkit/pull/5), which is waiting on feedback from @Hopding at the moment. For now,...

`Number.MIN_VALUE` is 5-384. Assuming you're using millimeters, this line would become the new smallest observable thing in the universe!? That said, I would consider this a bug. Looks like [numberToString](https://github.com/Hopding/pdf-lib/blob/93dd36e85aa659a3bca09867d2d8fac172501fbe/src/utils/numbers.ts#L11-L33)...

Hi @bridger, I've not tried your example, but this may be resolved by [this PR to fontkit](https://github.com/Hopding/fontkit/pull/5) (which is a dependency of this project). Unfortunately it seems @Hopding is inactive...