Joe Miyamoto

Results 14 comments of Joe Miyamoto

FYI. I was trying to use this starter in my monorepo and bumped into some troubles along the way. the biggest problem was that git treated the library as a...

私もlatestが良いかと思います。

All LN involved TX specifies `sequence` value explicitly in BOLT03, so we don't need this. In fact in the case of TX which requires two signatures, we only exchange the...

Miner fee problem is addressed recently by `option_anchor_output` feature, which is not reflected in this library yet :(

See [bitcoin-optech newsletter](https://bitcoinops.org/en/topics/anchor-outputs/#:~:text=Anchor%20outputs%20are%20special%20outputs,signed%20by%20the%20participating%20parties.) for `option_anchor_outputs`

Just for the sake of consistency and performance. It is fine to use Newtonsoft as well.

Consistancy with other part of the test code. Correctness does not change by witch json library we use.

Interesting. Well, in this case it is just for reading json from flat file so I don't think it is a big deal. But I got your point.

I'm not 100% sure if the mutable collection is what causing this. It may be something specific in Infrastructure tests. Anyway, #98 might be a solution if it is too...

Thanks, I didn't have enough time to review the init message handling in detail. (especially it seems that the spec has changed recently)