Joel Nitta comments

Results 91 comments of


                                            Joel Nitta

Any plans to put roxyglobals on CRAN?

Thanks! Feel free to close depending on what you decide to do about CRAN submission. I'll let you know/reopen if your suggestions don't work for some reason.

canaper: Categorical Analysis of Neo- And Paleo-Endemism in R

I forgot to mention, I plan to submit this as a paper to *Methods in Ecology and Evolution* after ROpenSci review (have also added this to the original description)

canaper: Categorical Analysis of Neo- And Paleo-Endemism in R

@luismurao thanks so much for your review! I will try to address your comments soon.

canaper: Categorical Analysis of Neo- And Paleo-Endemism in R

@KlausVigo it would be great to have your comments as well so I can make changes incorporating both sets of reviews.

canaper: Categorical Analysis of Neo- And Paleo-Endemism in R

@KlausVigo, do you still intend to review this package? If not, @tdhock can you please assign a new reviewer, as it is now multiple months past the due date. Thanks!

canaper: Categorical Analysis of Neo- And Paleo-Endemism in R

@KlausVigo thank you very much for the extensive and helpful review! I just wanted to address one thing first: the reason I copied functions from phyloregion instead of importing them...

geom_hilight with gradient does not show anything

Thanks for the quick reply. That doesn't seem to work for me. Perhaps it is because you are using an older version (3.1.5.900 vs 3.3.1). If so, it needs to...

geom_hilight with gradient does not show anything

Thanks, I will try it on linux

render_rmarkdown() should surface R Markdown errors better

+1: I have also just [encountered this](https://github.com/joelnitta/canaper/runs/8031830170?check_suite_focus=true), and even though a similar [cryptic warning as above](https://github.com/r-lib/pkgdown/issues/2169#issuecomment-1228274536) was issued, the actual problem (missing `library()` call for a particular package) had nothing...

Parser::parseGTF => Data Structure returns an empty hash

PS: the `Possible precedence issue with control flow operator` warning shows up even with the test data, so I don't think that has anything to do with the above error....