Joel Unzain

Edge case not handled in prometheus makeLabels function

4

The following function (https://github.com/go-kit/kit/blob/master/metrics/prometheus/prometheus.go#L161 ) will have an index out of bounds error when labelValues is of odd length. In the odd length case, one approach is to ignore the...

We should also log the WRP's destination field to provide more context around the check. https://github.com/xmidt-org/webpa-common/blob/5150386d727c4b6dad78981a89a1afab909cef02/device/manager.go#L307

OpenTelemetry Change Clarification

3

This relates to https://github.com/xmidt-org/webpa-common/pull/569 Our best guess as to what this change is proposing is ensuring that the device connection manager uses a logger that's enriched with tracing information but...

Adding a license will make it easier for the community to use the repo and contribute to it. https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository

`venuetypelist` format is ambiguous in the spec

2

I know the following two are supported formats to represent a venue type. # `venuetypeid` The spec makes this format pretty clear. I understand that this integer ID may be...

Enumeration ID Limits of the current spec

1

With the current spec, there are limits as to how many different enumerations we can have at any of the parent, child or grandchild levels. For example, at the parent...

One of the Taxonomy types supported by oRTB is Open DOOH. We are looking to use their spec but cannot do so freely because they don't have a license associated...