Joe

> 1. Why 50? Do you have any specific reason why 50 is good there? Or, shouldn't it be user-configurable? Actually, I don't know which number is best, so just...

Got your point and noted. Let discuss about the number of limit record. In my opinion hard code number is enough. If the connector needs to get it from config,...

Hi @hiroyuki-sato This patch is only impact on `embulk preview ...` command, so there is no issue with incremental loading. About raw query, I think it can work. It's just...

Hi @hiroyuki-sato Yes, you're right. If user input raw query and the query contain top/limit, the current logic still append it and cause a problem. It's much more complicated to...

Thanks @hiroyuki-sato for your suggestion. Actually I don't like to add more configuration for user, it can put user to spend more time on correct the config and easier to...

I think the constant `MAX_PREVIEW_RECORDS` is just limit number of record for `embulk preview ...` and it avoid to scan all records from table to make query a bit faster...

Thanks for your feedback and suggestion. Totally agree with you about the make it configurable. But currently behavior is the plugin print only 127 records for the samples even if...

I think the embulk internally handle page by page with limit page size is 32768 bytes. So, the number of preview lines will be very and depend on size of...

In the preview it just handle first page only: https://github.com/embulk/embulk/blob/v0.11.0/embulk-core/src/main/java/org/embulk/exec/PreviewExecutor.java#L175 and skip the remaining page.

As my understand, it consumed first page (32678 bytes) and check number of rows from first page with default sample row config ?