Jaroslaw Odzga

Results 12 comments of Jaroslaw Odzga

Thanks @markj-db and @gibbscullen for following up. Mark, you are right lack of sorting is not the problem. The m3 implementation does sort the buckets by `upperBound` in `sanitizeBuckets` function:...

@gibbscullen I believe this is a pretty serious problem. AFAICT histogram_quantile queries for high percentiles will return wrong result. I'd love to help out but I am not a golang...

I looked deeper into it and found out that the problem is that for one of the queries made by the plugin ReveiwBoard server returns 500: https://rbserver.com/api/repositories/9/info/ There are few...

Looked into it and it turns out that this is an expected behavior: https://www.reviewboard.org/docs/manual/1.5/webapi/2.0/errors/210-repository-info-error/ I think a correct behavior for the plugin would be to ignore this error and continue....

I verified that it is caused by repository. Visiting repository returns: ``` Could not open the requested SVN filesystem ``` It would be great if plugin could ignore it, perhaps...

I agree that documentation does not clarify this and it is probably most misunderstood aspect of parseq. I will provide better description on the wiki. Thanks for bringing this up!

Jvadoc should at least mention ParSeq execution model.

One possibility is to create a custom FindBugs rule. It should not be too hard: refactor rule that validates @CheckReturnValue annotation with a twist that it applies to all methods...

It would be helpful to know more details about your use case but such situations we typically reuse a function that returns new task. You can see example use of...

Thanks for the suggestion. I believe I understand what you mean. There is a tradeoff to consider here. Allowing to run tasks more than once would make your life slightly...