jochong comments

Results 9 comments of


                                            jochong

[microservices] KafkaRequestSerializer not serializing a object with attribute name "value"

I've created a fix PR #13375. Could you take a look? :)

Base exception filter ignores exception cause

I've created a PR #13681 Could you take a look? :)

feat(core): print cause of uncaught errors in their stack trace

I've updated the test cases for the exception handler and submitted a PR for your review. https://github.com/thibseisel/nest/pull/3 --- I noticed an issue in the existing test code, so I made...

feat(core): print cause of uncaught errors in their stack trace

@thibseisel I’ve been thinking about the decision to print only the `cause`. I wonder if there might be value in printing all attributes of the Error object instead. I believe...

feat(core): print cause of uncaught errors in their stack trace

@thibseisel @kamilmysliwiec Hello, I've been developing with Nest.js recently and had some thoughts that I wanted to share here. For smaller-scale servers, I think the default logger could work well...

feat(core): print cause of uncaught errors in their stack trace

I'm sorry. Controlling whether to log all properties through environment variables might not be the best approach. Instead, I think it would be better if this could be controlled appropriately...

feat(common): modify Logger to allow setting a prefix

@micalevisk Hello, thank you so much for your feedback. I overlooked the useLogger method. Adding a method to INestApplication that allows modifying the prefix could cause confusion with useLogger. So,...

feat(core): Modify BaseExceptionFilter to print exception properties

@benjGam This PR is simply a PR written for code comparison. I think it would be good to track it in #13870.

useMutation callbacks context type depends on options object sorting

I've created PR #9186 Could you take a look? :)