Jonas Nicklas

Results 59 comments of Jonas Nicklas

Matt: did you work out any way to set the accept header? Seems like Akephalos doesn't allow configuring this header, right?

I found one workaround, actually. The problem for me is the redirect in Devise when authentication fails. Solution: don't let authentication fail ;) So by changing: ``` - visit(root_path) +...

It's also inconsistent between matching a query parameter, which makes the extraction match _any_ query parameter, and not matching a query parameter in which case we can't provide any query...

If you don't mind the extra dependency, I wrote this in the meantime, which adds outer joins: https://github.com/elabs/ar_outer_joins This solves the problem even better because it doesn't have the ugly...

@ryanb why did you pull in 02841bbc195cdb17c6a4f511da44e0040e80f5f7, when this does the _exact same_ change, except this also adds tests for the incorrect behaviour?

Ah, I see, this may not be entirely clear. Thanks for reporting! We support both `Generator` and `GeneratorFunction` as an operation. When you have a generator function like this: ```js...

> what about stream.merge() as in myProcess.stderr.merge(myProcess.stdout).forEach() Totally an option. I preferred the function style, since no stream is preferred over the other, so the result looks more symmetrical to...

The problem is that there are legit cases where percolating a failure to the root is intentional, such as when using `run(...).catch()`. It can be challenging to distinguish when it...

And false warnings are incredibly annoying, so we should be careful with that.

> This looks amazing! Sorry I've taken so long to get to reviewing it, but I didn't have much time last week. > > I am curious about the dynamic...