Jason Sykes
Jason Sykes
I will work on this.
I will let you take the lead on this one. Was there any direction or ideas you had in approaching this.
I know I can do this: ```python @pytest.mark.filterwarnings("ignore:Trial0") def test_filter_nonfinite_with_invalid_target() -> None: study = prepare_study_with_trials() trials = study.get_trials(states=(TrialState.COMPLETE,)) with pytest.raises(ValueError): _filter_nonfinite(trials, target=lambda t: "invalid target") # type: ignore ``` But...
If these trials change in the future, we might not want to filter them. Maybe we can use a filter like: `ignore:Trial0.*float`? This way if this trial ever changes it...
Did we need to filter the `user warnings` for `test_parallel_coordinate.py` as well? If so, all of them or just the ones with the ` Attempting to set identical bottom ==...
> I'd suggest sending a PR modifying at most a few files such as only `tests/visualization_tests/test_utils.py` at first, not for all visualsation tests. This is what I am doing
So we don't work on the same test. I will be sending in a pr once I finish some final tests. These are the files I worked on: ``` modified:...
Ok, If I understand correctly. You want only the ones with your comments on them addressed? Is this correct? Or this is just a compilation of the files that need...
Can you give me a list of files you want me to work on? This way we are in sync. I don't want to have overlapping effort.
This is fine. I will work on these.