Jesse Rosenstock comments

Results 231 comments of


                                            Jesse Rosenstock

Better to use enum class instead of enum

Sure. You can call them `kBegin`, etc.

Better to use enum class instead of enum

I mean, send a PR to change it to: ``` enum class InitialPosition { kBegin, kEnd, kUnpositioned }; ```

Add support for find_packge?

What do you mean by "invalid"? It looks like you just need to keep building with `-DS2_USE_GLOG` if you want to use glog. How should we use `find_package` to make...

[WIP] Create cmake.yml

Ignore this for now -- just starting to play around. I need to install absl and the other dependencies.

Port to C++20.

What's the minimum c++ version needed for this to work?

Port to C++20.

This isn't compiling: https://travis-ci.org/github/google/s2geometry/builds/696839883 C++20 is too new to require. C++14 is definitely ok and C++17 is probably ok.

Port to C++20.

> With this patch, s2geometry can be compiled with gcc 10. gcc 10 works without this patch. https://travis-ci.org/github/google/s2geometry/jobs/722137049#L423

Port to C++20.

I will close and re-open this in hope of getting travis-ci to notice the `.travis.yml` changes. The current `CMakeLists.txt` is incompatible with the old `.travis.yml`.

This breaks both compilers that support c++20 https://travis-ci.org/github/google/s2geometry/jobs/722649190#L544 and those that don't https://travis-ci.org/github/google/s2geometry/jobs/722649187#L324

Clip Arc To Cell

Again, what is the higher level problem you're trying to solve? It seems like you might be working at too low a level. There might be other tools that solve...