James McShane
James McShane
Thanks for the response, the motivation for avoiding the lima-provided settings makes sense. I think restarting colima would be an acceptable workflow after editing the containerd config.toml file.
ok, im looking into the code here for the docker daemon and i do wonder if we need some default settings in the containerd config.toml for it to start up...
I have created an initial implementation of this: https://github.com/jmcshane/interceptor-sdk Its not exactly in line with the knative webhook package linked above, but it does add a couple necessary pieces: *...
The `interceptor/sdk/sharedmain.go` file is templated based off the knative pkg sharedmain: https://github.com/knative/pkg/blob/main/injection/sharedmain/main.go. I do wonder if some of this code could be removed in favor of referencing that package directly
/assign @bobcatfish
> The interceptor/sdk/sharedmain.go file is templated based off the knative pkg sharedmain: https://github.com/knative/pkg/blob/main/injection/sharedmain/main.go. I do wonder if some of this code could be removed in favor of referencing that package...
An idea that's been bouncing around in my head is the concept of extending what can be "done" with interceptors. This is in line with what we've discussed with nested...
One challenge with this implementation is that you have to return an interface from the New function. Generally, in go, the desire is to return objects and accept interfaces. I'll...
1. There was an existing `interceptors` package, so I moved this down into sdk. I can move this stuff up into the top level package. 2. I did think about...
One challenge that this Initialize method presents is it does move away from the golang standard "New" function. The `NewController` function in each of the current interceptors allows each interceptor...