James McCreight

DeepDiff pathlib.PosixPath objects

1

First off, deepdiff is great. Thanks. I found the following behavior somewhat surprising. (The failure is on the last line, my expectations are set on the preceeding lines) ``` import...

Feat/var meta

1

This is really a shoe horn to get a human-readable format (e.g. a flattened csv in the source) into a new memory manager field for attributes (using keys/hashes to ensure...

CHANOBS output file should include the nudge. Should CHANOBS contain the channel-only fluxes as well? I think we could go either way, my penchant would be NO because the full...

NaNs in FRNG test case

2

This appears to be a domain issue with the front range Route_Link file. There are 3 reaches with NaNs in the test case 4DAY/NHDPLUS run, for the entire length of...

when dt/dtrt_ch is not an integer

2

I dont know if this is important to flag or not. I was running LSM DT = 900 sec and DTRT_CH = 120 sec. I'm not sure what the ouput...

Restart runs: internal times in CHANOBS and CHRTOUT_DOMAIN files are incorrect

1

(This is the case when model time matches the time in the restart file, not same as previous bug). The times calculated for CHANOBS and CHRTOUT_DOMAIN share a common bug....

FATAL ERROR return code is 0

3

``` The job is stoped due to the FATAL ERROR: failed to read the hydro restart file RESTARTS/HYDRO_RST.2015-05-01_00:00_DOMAI N1.23 ``` but ``` echo $? 0 ``` An easy fix, but...

Testing needs to log the git hash.

1

The test results are otherwise disconnected from the code.

If the nudgingParams.nc file does not jive with the Routelink, there is a silent failure. ## Expected Behavior A moaning, weeping, gnashing of teeth in the output files, somewhere. ##...

Create a time module

1

## Expected Behavior It's reasonable that there would be a central location for calculating and managing time variables. ## Current Behavior Currently there are time calculations happening all over the...