Jean-Michel Campin
Jean-Michel Campin
Just a minor comment here, default minimum fraction might be 0.2 but we more often use a smaller value (e.g., 0.1 or smaller). On Wed, Feb 16, 2022 at 06:18:05PM...
Just a detail:sigma coordinate does also moves in time with SSH (when the bottom is flat, sigma and z* are the same).
Somehow related, issue #184
The location of this call to LOOK_FOR_NEG_SALINITY is not ideal: a) if we really want to reset negative salinity to zero, I agree with Martin (@mjlosch) it would be better...
I have few preliminary comments: 1. It would be better to keep the default DIC_OPTIONS.h (from pkg/dic) unchanged. Switching CARBONCHEM_TOTALPHSCALE and CAR_DISS to "#define" also affects the TAF adjoint and...
I took a (very) quick look and LGTM. Going to merge this PR soon (tomorrow ?) unless someone wants to add something.
Regarding _nthreads_chkpt_ , you are right: each time it appears in the code (in: the_main_loop.F and in pkg/smooth/smooth_diff2/3d.F) it's multiplied by nSx\*nSy. But whether we run single thread or mutlple...
@mjlosch I agree with your plan for a draft PR.
Hi Tim, I don't remember the exact details, but I remember that I mentioned to Martin that the pieces of code for OBCS-balance with shelfice was doing something meaningful but...
@mjlosch Do you have a precise idea about why the output of exp. exp4.stevens are changing ? cg2d is down to 8 digits match but when I look at differences...