Julien Laffaye
Julien Laffaye
maybe due to the setInterval in Notification.
If I comment both setInterval, resource usage goes down significantly. I think I can remove the setInterval in Notification and replace it by two call to tick() while keeping its...
Oh, yes, the timeout is for opening the TCP connection. It is not currently used for every read/write.
Maybe we should have a function implementing `ABORT (ABOR)` for this case.
Can you please add tests for this ? I think it'd make sense to extract the new code in a new helper function `isBogusDataIP(cmdIP, dataIP) bool` so it is easier...
Can you please add a test case for this new function ? Also, I agree, we should come with a better name since Stat is confusing.
Dup: https://github.com/jlaffaye/ftp/pull/269
Is it the same as https://github.com/jlaffaye/ftp/issues/249#issuecomment-1056765804 ?
Do you think it is possible to upload this module to OPM ? Currently there is a fork of this module on OPM, but not the official one.
Can you please add a comment in the code to explain why we setup the connection with tls.Client and not tls.Dial ? So we dont forget about this in the...