Jonas Lähnemann

Results 216 comments of Jonas Lähnemann

> The "Duplicate" action is a cheap Template-like behavior, to create something that is not empty/default template, based on an existing experiment. This is the use case that I see...

I did not add screenshots, but quite some more details to the CONTRIBUTING.md in #67

If continued, needs to be rebased on and adapted to #2972?

`non_uniform_axis` is merged in #2399. However, if I understand this one correctly, it is more about labels at predefined (non regular) positions.

Note that LGTM will be discontinued at the end of the year in favor of GitHub Code Scanning: https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/ So it makes no sense to update anything in the user...

How about setting it up for RosettaSciIO for the moment, test it there for a few weeks and then implement it here in HyperSpy? In the meantime, could you review...

> For the review, it would be good to use the analysis tool to understand how it should be fixed. Did you use https://lgtm.com/projects/g/hyperspy/hyperspy to find what needs to be...

Probably it is a question of how my gui is set up, but I do not get a button to apply the cropping. Also, is it restricted to certain types...

OK, but wouldn't it make sense to implement such a interactive cropping tool in a more general way that could work also on e.g. the navigation image of a 1D...

`set_axis()` is used e.g. in LumiSpy, when replacing e.g. a wavelength axis by an energy axis: https://github.com/LumiSpy/lumispy/blob/afd9723aec9ea45888ba60c03441909edbc64e33/lumispy/signals/luminescence_spectrum.py#L161