Jan Kuchař

Results 56 comments of Jan Kuchař

That unfortunatelly does not say much. I would prefer for `string[]` replace with `string[]|Traversable`. As: - IDE should understand the first part - static analyzer whould translate type as `string[]|Traversable`...

@ondrejmirtes Could @phpstan 0.12 also benefit from this work to make this available to even broader user base?

Isn't this ready to be merged? (even incomplete) :-)

Please, could you try to fix build and send another PR for CI fix?

Could you please propose a fix for this?

Yep, this is because it uses Nette\Object, which is not supported on PHP7 because of its name. Could you please provide pull request which uses SmartObject instead? https://doc.nette.org/cs/2.4/smartobject

There should be no more incompatibilities, just this formal one.

The same problem here! with PhpStorm 2021.1.1 (plugin version 2020.3.0-buit-for-ide-2021.1.x). ``` java.lang.IllegalStateException: @NotNull method com/intellij/diff/tools/simple/SimpleDiffViewer.getSyncScrollSupport must not return null at com.intellij.diff.tools.simple.SimpleDiffViewer.$$$reportNull$$$0(SimpleDiffViewer.java) at com.intellij.diff.tools.simple.SimpleDiffViewer.getSyncScrollSupport(SimpleDiffViewer.java:359) at net.ntworld.mergeRequestIntegrationIde.diff.TwoSideTextDiffView.calcPositionEditor2(TwoSideTextDiffView.kt:138) at net.ntworld.mergeRequestIntegrationIde.diff.TwoSideTextDiffView.initializeByLogicalLine(TwoSideTextDiffView.kt:41) at net.ntworld.mergeRequestIntegrationIde.diff.TwoSideTextDiffView.initializeLine(TwoSideTextDiffView.kt:50) at...

There is one more problem to fix, there is also WARNING mode in which dibi probably should mute warnings and handle them by iteself consistently = throwing exception. I would...

One more thing - I will need to help a little with tests. What approach to go? Run all tests also in warning mode and exception mode? Or create just...