Julian Krzefski
Julian Krzefski
No, I did not run any tests on my end. I only looked through the code, spotted this and thought it looked wrong. The travis build seems fine, though. I...
I would prefer a more versatile approach to this. Something like this would be better: ```php $this->web = new Server(sprintf('%s:%d', $this->host, $this->port), $this->loop, ['tls' => [ 'local_cert' => '/etc/letsencrypt/live//fullchain.pem', 'local_pk'...
Please include in your PR a way to dump this context into the configuration json file.
@SimonFrings That you for your feedback. (And sorry for my late response 😥) I opened a discussion about this topic. https://github.com/clue/framework-x/discussions/192
Although I don't know so much about this matter, I'd like to see this PR get merged (or refined so far that it becomes mergeable). I had some encoding troubles...
I would also be interested in the source code.
@kleinmann Yes, that sounds like a good idea. However, it might not be as necessary, since every domain in a sales channel should look the same. But yes, for maximum...