Jaco Kroon

Results 225 comments of Jaco Kroon

This is very interesting. Regarding the scripts, not all use cases require them to have root :). Consider pppd as part of a ras service ... this would in most...

Hi, We have multiple sources of where ppp+ comes from, so ppp+ doesn't quite get us there. Also, different users have different firewalling policies applied. So we don't need the...

@Neustradamus this might be addressed by https://github.com/ppp-project/ppp/pull/298 indirectly?

> > In principle this looks good and I'm in agreement. I've only looked over the code, and I've not actually tested this right now, happy to assist with that...

I think the principle is useful. To basically have access to the configured but not yet UP interface. It's not always possible to make firewall and shaping changes using patterns...

Thinking about this a little bit more: I'd be in favour of a single consolidated pre-up script, where it can also be mentioned explicitly that the script it allowed to...

@enaess ok, so this is a possible suggestion then: Deprecate ip-pre-up and just a more generic pre-up? Related to this, the lcp-up/down, which looking at that again, I suggest a...

> Frankly, this is an area of the code I don't know very well (yet). The introduction of a wait make me a bit eerie, and I too have had...

> I think you are on the right track here. Instead of introducing the ip6cp_pre_up script (with possible race conditions), the entire ip-pre-up should really be renamed to pre-up, or...