Jaakko Lappalainen comments

Results 12 comments of


                                            Jaakko Lappalainen

🐛 Bug Report: Collection attribute with name 'order' causes exception on listDocuments()

Seems like there's a collision between the `order` parameter name in the collection and the `order` SQL clause

Incorrect websocket close code on server shutdown

I just reproduced the issue and confirmed the code 1006 is used even after commenting out ```shell diff --git a/uvicorn/protocols/websockets/websockets_impl.py b/uvicorn/protocols/websockets/websockets_impl.py index 9a07a5d..a90dc1c 100644 --- a/uvicorn/protocols/websockets/websockets_impl.py +++ b/uvicorn/protocols/websockets/websockets_impl.py @@ -97,7...

Type Annotation and mypy support

@Kludex are the files without a PR associated "up for grabs"?

[FEATURE] Ability to pass connect_args to FastAPISessionMaker

Perhaps I'm lacking some context here, but you could create your custom `SQLAlchemy` engine and pass it to `FastAPISessionMaker` as its `_cached_engine` property. Would this help?

[FEATURE] Ability to pass connect_args to FastAPISessionMaker

Granted, setting what it seems to be a private variable feels like a hack to me, so I understand that not being documented. If the maintainers (@dmontagu) agree I can...

[FEATURE] Adjust task delay duration before first call

Im happy to take this one

Configure all promise returning functions as async functions

@medikoo added one PR for `lib/plugins/aws/remove` folder #9284

Deploying functions using node 14

FWIW, Im able to set the node version using another action in my step like so ```yaml - uses: actions/setup-node@v2-beta with: node-version: '14' ```

Error: An unexpected error has occurred.

@chenly try running the deploy command with `--debug`

Doesn't work

It worked for me I used node v16 and `npm install` rather than `yarn`