Josh Kline

Results 13 comments of Josh Kline

> @jkanywhere This sounds interesting. Can we interest you in bringing this over to [http://github.com/golang-jwt/jwt](https://github.com/golang-jwt/jwt) with a new PR? Yes. Please use https://github.com/golang-jwt/jwt/pull/33 instead.

Looks good to me. I agree YARPC should support all the error codes for all the protocols. YARPC codes are described [in yarpcerrors/codes.go](https://github.com/yarpc/yarpc-go/blob/dev/yarpcerrors/codes.go#L31).

I would also appreciate clarification please. Both of the above seem to follow > A newXYZ()/NewXYZ() may appear after the type is defined, but before the rest of the methods...

Also related, the "Do not group declarations that are unrelated" **good** example shows ``` type Operation int const ( Add Operation = iota + 1 Subtract Multiply ) const EnvVar...

> I'll clarify here before adding more detail to the guide, but at a high level, the guidance for ordering types in a given file is: > > * for...

> > Adding app and env to URI path implies a hierarchical relationship when there is none > > The spec does not specify hierarchy in any portion of the...

Good question. We do not have a full staging environment, instead staging and production are intermingled on the same cluster. When teams choose to run a staging copy of their...

What is the expected difference in behavior between `Invoke` in an `fx.Module` vs `Invoke` at the root level? Also, the internal ticket GO-1676 is closed Won't Do. Perhaps this issue...

I think this issue is fixed by https://github.com/uber-go/fx/pull/953 which adds support for functions with and without context parameter and error return.