Jeffrey Phung comments

Results 15 comments of


                                            Jeffrey Phung

Add tagging, object typing, fix pep8

Looks good to me! The `tag` can function like an id to identify specific trades correct? And would unit testing be helpful here or would it be redundant?

Contrib factories

Nice features! Will you be looking to merge this?

Example: Compiling and Running general JArduino class

I haven't used Maven but I am using Eclipse and linking libraries to my projects. I can guide you using this method but maybe Maven is similar. https://github.com/SINTEF-9012/JArduino/wiki/2-Minute-Tutorial

Error in Demo_MultiCrypto_Trading.ipynb

In order to fix the `baostock` error, just run `pip install baostock`

Error in Demo_MultiCrypto_Trading.ipynb

I recommend some github pre-commit hooks, checks, or actions to help standardize things and make the dev teams' lives easier. In addition to streamlining code commits and reducing overhead, it...

Lots of requests without problems?

@TravelTrader this repo still works for you? I tried the basic example on the Readme, but it throws an error: `MorningStar cannot find the ticker symbol you entered or it...

Resolves resampling issues due to timezone differences.

@datatalking Unfortunately, even backtrader2 doesn't look like it's actively maintained. So far, I have found 2 forks that seem to be actively maintained: - [Publicly managed repo and open for...

not working

Fixed with: https://github.com/agermanidis/autosub/issues/186

Single stock example is broken, unable to fetch Yahoo/Google data

Same problem Versions Pyfolio version: 0.9.2 Python version: 3.6.10 Pandas version: 1.0.5 Matplotlib version: 3.2.2