jjdredd
jjdredd
The key files to look at: ``` src/xrCore/CLOptions.h src/xrCore/CLOptions.cpp src/xrCore/xrCore.cpp src/xrCore/LocatorAPI.cpp src/xrEngine/main.cpp src/xr_3da/entry_point.cpp ```
> What you've done is just re-invention of [cxxopts](https://github.com/jarro2783/cxxopts) This isn't my design, but I haven't heard of cxxopts > The initial code has an issue (e.g. `MODEL::build()`) where an...
I think declaring a command line option as global variable in a header is dangerous, since a header may be included in several different compilation units and there will be...
What's happening with CI?
I think this PR is almost ready for the second review. There are two things that I'm not sure of: 1. I don't think it's not sufficient to just add...
> 2\. It is possible to remove memory allocations and use `pcstr`. Please, use `pcstr` without memory allocations. Wait, I don't get it. I thought I'm supposed to use a...
> To avoid modification of the original string, you can use temporary string on the stack in the initialization function. Hm, I could just store the key name without the...
ok, it's not hard to change then. we'll require the programmer to provide the key name with static lifetime and with no `-` in the key name.
Для хранения переданных строк с ключом тоже использую указатель просто копируя соответствующий из argv. Сквашну естественно после апрува.
> Excuse the ignorance, but wouldn't it be better adopting existing C++ libraries That has been discussed.