Joel Davies
Joel Davies
I'm temporarily out of the C+ team as I'm about to go OOO, so the auto-assigning isn't working here. Tagging @tgolen on the PR to give it a quick review,...
@tgolen Sure, will get to that today!
Tough decision here :smile: @Nodebrute's [proposal](https://github.com/Expensify/App/issues/39660#issuecomment-2038337679) does work, but I feel that it makes the code a bit unreadable (in an already pretty hard to parse set of conditions). I...
@marcaaron Oooh thanks for the heads up on that PR! I like that idea in general of adding those extra helper functions, but I wonder if it's worth it if...
> What do you think about my alternative solution here. @nkdengineer Your alternative solution would allow leaving the group chat through a different method from what has been added in...
Just flagging that this PR caused a bug where the cursor position would freeze after pasting emojis. The root cause is the reliance on `setState` in `updateComment` when setting the...
## Proposal ### Please re-state the problem that we are trying to solve in this issue. The emoji picker is appearing in between selecting the attachment menu item and the...
Updated [proposal](https://github.com/Expensify/App/issues/16977#issuecomment-1499083254) with extra details regarding handling cancelling the file picker. @allroundexperts I don't think your first solution does anything as far as I can tell, since the delay is...
@sobitneupane Sorry for not being clearer! I meant that we can add an event listener on the window to check when it receives focus, as this will reliably trigger when...
@sobitneupane Ah good catch! On my device the modal appears instantly, so I wasn't getting the same issue. The solution would be to update `AttachmentPicker` so that we remove the...