Johannes Jank

Results 8 comments of Johannes Jank

Are you still planning to change the method signature in `1.0.0` @lhazlewood ? It would be great to ditch that `@SuppressWarnings( "rawtypes" )` annotation in my code 🙂

With the configuration I described you _actually_ get metrics from DBCP2 - I should have been more clear about that. You "just" will see a lot of errors in the...

@shakuzen I've recently stumbled across [jfrunit](https://github.com/moditect/jfrunit), Gunnar Morling has a blog post about exactly this topic - [detecting an increase in memory allocation](https://www.morling.dev/blog/towards-continuous-performance-regression-testing/). I haven't played with it myself but...

@shakuzen in case I *actually* find time for this: What would be a good place to start / which code paths are especially allocation-sensitive?

Hi there ! I noticed that as of version `2.10.0` the underlying Connection pool (i.e. the `org.apache.commons.pool2.impl.GenericObjectPool`) is exposed publicly: https://github.com/apache/commons-dbcp/commit/54ef9d3d7ee4d07d792d287c768f8b402306e55b in [BasicDataSource.java](https://github.com/apache/commons-dbcp/blob/master/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java#L770). (In a [previous discussion](https://github.com/micrometer-metrics/micrometer/pull/1712#discussion_r349060838) this was the...

+1 for AsciiDoc with Antora. The Spring-Framework docs [switched to Antora recently too](https://spring.io/blog/2023/05/11/spring-framework-reference-documentation-update)

Can I just randomly throw an idea in here @cpovirk ? I'm not sure if you are aware of the [OpenRewrite](https://docs.openrewrite.org/) project. If not, I'd strongly reccomend to get in...

Also adding a +1 here - would be _really_ helpful for us