Joffrey JAFFEUX comments

Results 39 comments of


                                            Joffrey JAFFEUX

FIX: Better virtual keyboard detect on Android

@xfalcox If I may recommend you a better approach here, which would allow me to use this in discourse-chat too without having to duplicate stuff: tag less component. `{{keyboard-visibility-handler}}`which would...

FEATURE: Introduce personal_message_enabled_groups setting

Maybe we move allowPersonalMessages to current user service, in your code it's only code using current user as a param afaict. This way we can compute on current user groups...

DEV: use structured data in crawler-linkback-list for referencing only

Fixed the conflict, and will merge it tomorrow.

DEV: use structured data in crawler-linkback-list for referencing only

@rr-it I just merged it, thanks

FIX: display correct theme & color-scheme in other user's profiles.

@vinothkannans Is it something you still want to work on? I see this message from nat here: https://meta.discourse.org/t/changing-colors-themes-for-another-user-does-the-same-to-you/233674/18

do not require an email in smtp_should_reject handler

> Hey Martin, > > oh gosh, now I need to remember the context of this 😰 > > I think my reasoning was that with this change, the `handle_bounce`...

FIX: Validate asset url before replacing base url

I rebased and added a test to this one, @nattsw could you try to get someone to review this please?

DEV: declare post position as simple number in structured data

I will merge this tomorrow.

DEV: declare post position as simple number in structured data

@rr-it I just merged it, thanks!

add note about length of setup

Pathologic duration like this one should be investigated or ignored as due to other considerations. Please post more details on meta. Tanks. I will closet his for now.