Jon Insley

Results 22 comments of Jon Insley

> This doesn't look like an issue with our Vercel integration. Rather this looks related to our webpack plugin https://github.com/getsentry/sentry-webpack-plugin or the underlying sentry-cli > > Routing to @getsentry/sdks Should...

@rico-bee the parameters are here on line 94 - https://github.com/trader-xyz/nft-swap-sdk/blob/8b3c3ebfa868cbbb1beb59f49521b956faed0201/src/sdk/v3/INftSwapV3.ts Better descriptions of parameters here: https://github.com/0xProject/0x-protocol-specification/blob/master/v3/v3-specification.md#order-message-format

@MincePie - In the supabase-js v2 update, the cookies and auth method have changed and the newest Stripe Checkout setup is slightly different than what is explained in the course...

@callmejumeh @laurencebedford the repo I posted uses the auth helpers. I haven't updated it in 7 months though but it should still work.

It looks like typescript types are only in the `@novu/shared` package. `import { IMessage, IMessageAction, ButtonTypeEnum } from '@novu/shared'`

I'm having the same issue, can we set a higher gas limit like this? https://github.com/trader-xyz/nft-swap-sdk/blob/5782d110b8882f7490f33b80acf59cd6f2ea7301/test/v3/swap.test.ts#L81

Default `fillSignedOrder` seems to run out of gas for certain NFT collections for single swaps ERC721ERC721 plus fees: ```js const fillTx = await swapSdk.fillSignedOrder(normalizedOrder); ``` This gets over the limit...

> I have fork your project and create a fix, not being allowed to make a PR, here is a screen of the patch : > > (src/sdk/v4/NftSwapV4.ts): https://prnt.sc/c1G4i5T-Z13m (src/sdk/v4/types.ts)...

It returns `TransactionReceipt` as: ```js const fillTxReceipt = { accessList: null blockHash: null blockNumber: null chainId: 0 confirmations: 0 creates: null data: "0xe14b5....00000000000000000000000000000000000000000000000000" from: "0x0A...A0" to: "0x0...94" hash: "0x9eb...29" gasLimit:...

What happens to the original order after a partial buy? Can you still do another order from it or do you just cancel the remaining order?