JimboJ
JimboJ
It's enforced that the node value
Upon investigating we found these relevant parts of the grandpa package: - https://github.com/paritytech/substrate/blob/88731ed619f6be1280f01cc8f02f10e2fb4cf199/client/finality-grandpa/src/communication/mod.rs#L93 - https://github.com/paritytech/substrate/blob/88731ed619f6be1280f01cc8f02f10e2fb4cf199/client/finality-grandpa/src/communication/gossip.rs#L434 We think it will be useful to have a similar misbehavior function where we can...
The list of tasks involved in this issue will be split between @EclesioMeloJunior and myself. The plan currently is to work together to develop the framework for handling reporting and...
Closed and replaced with #2809
@timwu20 https://github.com/ChainSafe/gossamer/pull/2809#discussion_r983858307 so you think good to move this call to just above handleChainReorg? Just wanted to confirm before changing since will need to update tests
@timwu20 https://github.com/ChainSafe/gossamer/pull/2809#discussion_r983864001 so should I change the function signature to return an error?
It seems adding panics to handleBlockAsync has caused things to break. WIll further investigate
@timwu20 I think the core tests should be fixed now. Elizabeth cautioned against having these added panics, but maybe good for testing still? Your call
> * `lib/blocktree/mock_instance_test.go` seems like an appropriate name based on its contents, why has it been changed to `lib/blocktree/mocks_test.go` > > * We want to shut down the node only...