jilles-sg

Results 16 comments of jilles-sg

An interpolation without `{}` may still be useful if it corresponds to a `FormattableString` or interpolation handler (as opposed to a string).

`FormattableString` is a fancy tuple of a format string and an array of arguments. It allows doing basically the same as interpolation handlers, but works on older versions of .NET...

I'm associated with the same deployment as @sg-jorrit and have tried reading a little of the code. Just looking at https://github.com/slact/nchan/commit/f1a25dfba4d45bfa7cd311ad27554583d7dadf42, I think it is remarkable that `spool_fetch_msg()` is called...

Specifically, the new `webOSTV.js` is required to call `webOS.platformBack()` which is necessary for proper handling of the back button when disableBackHistoryAPI is enabled (which cordova-tv-webos does). See http://webostv.developer.lge.com/develop/app-developer-guide/back-button/

By the way, the RxPlayer freeze detection requires at least 2 seconds (`MINIMUM_BUFFER_AMOUNT_BEFORE_FREEZING`) of buffered data, so it will never activate if there's such an issue close to the end.

Left quiet here is that the `ArrayPool.Shared.Return()` call is not in a `finally` block. This is not wrong but how it should be (assuming that an exception is expected to...

In this particular case, the rule is correct, but perhaps not for the right reason. The `notnull` constraint allows both value and reference types and therefore `T?` is the same...

> FWIW here is a more practical usage encountering the same false positive: > ``` > public static class IEnumerableExtensions > { > public static IEnumerable > SelectNonNull( > this...

Like https://github.com/SonarSource/sonar-dotnet/issues/9664#issuecomment-2357877600 , `List.Exists` remained unchanged while `Any` was optimized.

`List.Find` has been unchanged for a long time and reads the list's fields on every iteration of the loop, while `FirstOrDefault` was recently changed to read the fields once and...