Ji Kim

Results 7 comments of Ji Kim

Left one nit comment, but everything LGTM. Are we planning to have a follow-up work on testing `ContainerSummaryView`? I think it will be really nice if we can test how...

```cjs /*! * Copyright (c) Microsoft Corporation and contributors. All rights reserved. * Licensed under the MIT License. */ "use strict"; const getFluidTestMochaConfig = require("@fluid-internal/mocha-test-setup/mocharc-common"); const packageDir = __dirname; const...

With the change in the `Reporter.ts`, errors are correctly logged using the table.

`benchmarkCustom()` is now able to report all the test results without crashing. https://github.com/microsoft/FluidFramework/pull/22245#issuecomment-2327650099 Also from the comment above, I wanted to make sure that the error messages from `--perfMode` and...

`pnpm run test` ![image](https://github.com/user-attachments/assets/e7302dc7-f426-4f71-bcfc-02dddcb51282) `pnpm run test:customBenchmarks` ![image](https://github.com/user-attachments/assets/0cc9e34e-a42d-42e6-9c06-124f3f1a05cd) `pnpm run test:customBenchmarks -- --perfMode` ![image](https://github.com/user-attachments/assets/1279628f-cae0-46a8-bae3-719c20d2ad17)

![image](https://github.com/user-attachments/assets/0522abe5-69af-4a51-ab1d-86d1ba4b04ca) ![image](https://github.com/user-attachments/assets/9b91f0d6-74dc-4cbe-9412-36cd1909cd50) Verified that the errors are logging in both `non-perfMode` and `perfMode`.

https://github.com/microsoft/FluidFramework/pull/22330 Looping @scottn12 @sonalideshpandemsft in.