Jihoon Son

Results 67 comments of Jihoon Son

Hey @FrankChen021, can you add some tests to verify the new response?

@FrankChen021 my apologies, I forgot to take another look. Please feel free to ping me if I forget again and don't finish my review in time. I took another look....

@FrankChen021 thanks for understanding. I will review #12295 soon.

Hi @JulianJaffePinterest, apologize for not having a look earlier and thank you for your patience! I know there are many people out there who want this, so thank you again...

> @jihoonson @samarthjain has been reviewing the pr but yes I agree it's too large to effectively review. I'm not sure how to reduce it to pieces though - splitting...

Hi @pjain1, have you checked https://github.com/apache/druid/issues/10352? This proposal describes some idea on ingestion metrics.

> @jihoonson The proposal looks great, I did this PR because bytes ingested is not available for streaming or batch tasks. I see your proposal only includes metrics for batch...

> @jihoonson are you actively working on your proposal ? do you think you can reuse the `InputStats` strategy from here ? @pjain1 sorry, I forgot about this PR. I...

Apologize, I accidentally clicked the button which published my previous comment incomplete. Updated it now.