Jan Hübner
Jan Hübner
I also hope that somehow maybe a 1.3 version in combination with kokuwaio/fluentd Helm chart resolves an issue Amazon started raising with customers: > "[Action Required] Amazon EKS - Update...
Nevermind, thanks @phntom for jumping in and having filled the gap.
> The change LGTM. Thanks @jhuebner79 . As I don't have any AWS setup and it is not part of the test suite, I don't really have a way to...
@franmomu I force pushed the code I suggested earlier, and your suggestion as well
oh no, the local tests are not running successfully anymore.. hang on please
Found it - looks good locally now (did another force push)
@ruflin @franmomu do you need to give approval for another workflow run? Is there anything else I can do?
We added another exclusion to `phpstan-baseline.neon` - would you please be so kind and allow for another workflow run please @thePanz @deguif ?
> @jhuebner79 I will check the indentation later, would you be able to provide some tests covering the added lines? Looks like the code-coverage is not picking them up 🤔...
@ruflin thanks for that! I still don't know why codecov is not happy or what I can do about it, but I think I would need to rebase to current...