jhorv

Results 21 comments of jhorv

@Sergio0694 frustration here. The fact that `[ObservableProperty]`s are public-public causes me to barely use it. If only I could specify a `private set`, then almost every one of my view...

> * Why does it need to be a _read-only_ segment? System.Buffers has several types (`ReadOnlySequence`, `ReadOnlySequenceSegment`, `ReadOnlySpanAction`, `SequenceReader`) that simplify reading potentially dis-contiguous segments. I don't know of any...

Okay, took this out of draft. This revised implementation does away with the `PagedMemoryRangeEnumerator` and `PagedMemoryRangeCoalescingEnumerator` approach, and instead consolidates page traversal logic by continuing the refactor of common methods...

@riperiperi would you please re-review? The approach to sharing page enumeration logic has been reworked entirely.

Or @LDj3SNuD, would you please review? This PR is 1 of ?, and parts 2 and 3 are waiting for this one.

@gdkchan @riperiperi rebased. I don't have hardware to test it on, so I was a little conservative with changes to `MemoryManagerHostTracked`. Specifically, there are 3 methods: - `WriteWithRedundancyCheck(ulong, ReadOnlySpan)` -...

Okay, found what I missed (needed to override `WriteImpl()`) and did some additional testing too. The crash you saw is fixed by this latest commit.

> It still hung on close a bunch of times, but I think there are a few other reasons it can do that (mostly GAL related). I wasn't able to...

> There are other custom pool implementations that we currently have, like https://github.com/Ryujinx/Ryujinx/blob/master/src/Ryujinx.Graphics.Vic/Image/BufferPool.cs Do you think this would be eventually able to replace those? They could be replaced, but I...

Major revision to this PR - LOH memory allocations in the test scenario are now reduced by 78%, with LOH allocated bytes reduced by 80%, from 3 gigabytes down to...