James Dark
James Dark
Hi all, I can't seem to have conda working reliably in a github ci workflow, I assume it has something to do with using mamba too? I do need this...
At the moment in the fenicsx branch sources, boundary conditions and fluxes (and `define_temperature` within `HydorgenTransportProblem`) have a function `create_value_fenics` or something similar in which we convert a user-given value...
`D_0` and `E_D` will also need to be optional arguments, as when running HeatTransferProblem, these values won't be required. But to prevent user error, we could incorporate tests to ensure...
As mentioned in #683, we could have a note within the README on the fenicsx branch noting which version of dolfinx the code has been tested against.
Saw this in the FEniCSx repo, a nice little way to test the demo scripts both in series and in parallel. Could be useful to incooperate something similar in FESTIM...
## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves...
## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves...
We would need to support surface reactions of the type: A + B C + D Where both sides of the reaction can have gaseous or adsorbed species. For example...
Need to extend beyond the tests in #965 Add another test which tests an advection field in the discontinuous mixed domain approach
We should also consider geometries which also vary in r and z in cylindrical and spherical coordinate systems here is an example test that could be adapted: ```python @pytest.mark.parametrize("length", [4,...